Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowered backoff max retries, limited number of threads created #100

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

DownstreamDataTeam
Copy link
Contributor

Description of change

The changes:

  • used paginationDetails "ON" on the first call for each big batch in order to create the right number of threads
  • lowered the backoff.on_exception max_retries to 3 and increased the factor value to 4
  • fixed a bug which, if there was a HTTP 500 error, the error was raised but the execution was blocked in an infinite loop
  • updated the README file

Rollback steps

  • revert this branch

Alexandru Rosca added 16 commits October 17, 2022 15:49
…o 'release/55'

[ECDDC-728] Pagination details "ON" on the first call

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!145
# Conflicts:
#   tap_mambu/helpers/client.py
#   tap_mambu/tap_generators/multithreaded_bookmark_generator.py
#   tap_mambu/tap_generators/multithreaded_offset_generator.py
[ECDDC-744] Lowered backoff.on_exception retries number and fixed a bug

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!149
@singer-bot
Copy link

Hi @DownstreamDataTeam, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

[ECDDC-761] Updated README file

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!150
@singer-bot
Copy link

You did it @DownstreamDataTeam!

Thank you for signing the Singer Contribution License Agreement.

@vivek-uno
Copy link

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants